Let the quota evaluator handle mutating specs of pod & pvc #51174
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/release-note-none |
k8s-ci-robot
added
release-note-none
k8s-github-robot
added
the
size/L
| // fail closed, will try to give an evaluation. | ||
| return true | ||
| } | ||
| // only uninitilized pvc might be updated. |
| @@ -147,6 +148,84 @@ var _ = framework.KubeDescribe("ResourceQuota", func() { | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| }) | |||
|
|
|||
| It("should create a ResourceQuota and capture the life of an uninitialized pod.", func() { | |||
There was a problem hiding this comment.
I leave the test here to show what the end goal is. I can move the test to #50344 if that's better.
There was a problem hiding this comment.
I think it's fine if 50344 uncomments it.
caesarxuchao
force-pushed
the
fix-resourcequota
branch
from
6e6bacd
to
4928c8d
Compare
|
@liggitt @derekwaynecarr @smarterclayton PTAL. Thanks. |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, smarterclayton Associated issue: 47837 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
There was a problem hiding this comment.
i would like your recommendation on how i can map your changes with the desire to do #51370
| // TODO: update this if/when pods support resizing resource requirements. | ||
| return admission.Create == operation | ||
| // Handles returns true of the evaluator should handle the specified attributes. | ||
| func (p *podEvaluator) Handles(a admission.Attributes) bool { |
There was a problem hiding this comment.
i have a goal to enable the following:
#51370
where do you recommend i best layer in the referenced goal with the need to support initializers?
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Background
The final goal is to address #47837, which aims to allow more mutation for uninitialized objects.
To do that, we decided to let the admission controllers to handle mutation of uninitialized objects.
Issue
#50399 attempted to fix all admission controllers so that can handle mutating uninitialized objects. It was incomplete. I didn't realize although the resourcequota admission plugin handles the update operation, the underlying evaluator didn't. This PR updated the evaluators to handle updates of uninitialized pods/pvc.
TODO
We still miss another piece. The quota replenish controller uses the sharedinformer, which doesn't observe the deletion of uninitialized pods at the moment. So there is a quota leak if a pod is deleted before it's initialized. It will be addressed with #48893.